Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize y coord before checking parity #86

Merged
merged 5 commits into from
Dec 1, 2024
Merged

Normalize y coord before checking parity #86

merged 5 commits into from
Dec 1, 2024

Conversation

xoloki
Copy link
Contributor

@xoloki xoloki commented Nov 30, 2024

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 30, 2024 •
edited
Loading

Deploying p256k1 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 62c98cc
Status: ✅  Deploy successful!
Preview URL: https://c3209952.p256k1.pages.dev
Branch Preview URL: https://normalize-has-even-y.p256k1.pages.dev

View logs

@xoloki xoloki assigned djordon and unassigned djordon Nov 30, 2024
@xoloki xoloki requested a review from djordon November 30, 2024 23:41
djordon
djordon reviewed Dec 1, 2024
View reviewed changes
Copy link

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we should add a test here.

@xoloki
Copy link
Contributor Author

xoloki commented Dec 1, 2024

This looks good, but we should add a test here.

Done @djordon

@xoloki xoloki requested a review from djordon December 1, 2024 02:00
djordon
djordon approved these changes Dec 1, 2024
View reviewed changes
Copy link

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅

@xoloki xoloki merged commit e9db1c4 into master Dec 1, 2024
6 of 7 checks passed
@xoloki xoloki deleted the normalize-has-even-y branch December 1, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djordon djordon djordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoloki @djordon