Fixed members/signin_urls endpoint to take admin api key #21284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
migration
|
It looks like this PR contains a migration 👀 General requirements
Schema changes
Data changes
|
cathysarisky
changed the title
9larsons
requested changes
Oct 15, 2024
ghost/core/test/regression/api/admin/members-signin-url.test.js
Outdated
Show resolved
Hide resolved
9larsons
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
LGTM. I've asked @mike182uk to also take a pass just because of the migration.
mike182uk
reviewed
Oct 16, 2024
...core/server/data/migrations/versions/5.97/2023-10-10-01-02-03-add-signin-urls-permissions.js
Outdated
Show resolved
Hide resolved
…0-01-02-03-add-signin-urls-permissions.js Co-authored-by: Michael Barrett <[email protected]>
cmraible
pushed a commit
to cmraible/Ghost
that referenced
this pull request
Oct 16, 2024
) closes TryGhost#16748 The members/:member_id/signin_urls endpoint currently only does cookie-based authentication. When TryGhost#21249 is merged, turning on 2FA is going to break any 3rd party processes that use it (including my social sign-in offering). This patch gives admin API keys 'read' permission on this endpoint, and enables 3rd party processes to handle user logins the right way, instead of via a staff member's email/password. Migration included. Feedback appreciated. I have the wrong name on my migration. I can see it doesn't follow the naming convention, but I'm not sure how the names are generated. --------- Co-authored-by: Michael Barrett <[email protected]>
dvdwinden
pushed a commit
that referenced
this pull request
Oct 24, 2024
closes #16748 The members/:member_id/signin_urls endpoint currently only does cookie-based authentication. When #21249 is merged, turning on 2FA is going to break any 3rd party processes that use it (including my social sign-in offering). This patch gives admin API keys 'read' permission on this endpoint, and enables 3rd party processes to handle user logins the right way, instead of via a staff member's email/password. Migration included. Feedback appreciated. I have the wrong name on my migration. I can see it doesn't follow the naming convention, but I'm not sure how the names are generated. --------- Co-authored-by: Michael Barrett <[email protected]>
tilak999
pushed a commit
to tilak999/ghost
that referenced
this pull request
Nov 20, 2024
) closes TryGhost#16748 The members/:member_id/signin_urls endpoint currently only does cookie-based authentication. When TryGhost#21249 is merged, turning on 2FA is going to break any 3rd party processes that use it (including my social sign-in offering). This patch gives admin API keys 'read' permission on this endpoint, and enables 3rd party processes to handle user logins the right way, instead of via a staff member's email/password. Migration included. Feedback appreciated. I have the wrong name on my migration. I can see it doesn't follow the naming convention, but I'm not sure how the names are generated. --------- Co-authored-by: Michael Barrett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16748
The members/:member_id/signin_urls endpoint currently only does cookie-based authentication. When #21249 is merged, turning on 2FA is going to break any 3rd party processes that use it (including my social sign-in offering).
This patch gives admin API keys 'read' permission on this endpoint, and enables 3rd party processes to handle user logins the right way, instead of via a staff member's email/password.
Migration included. Feedback appreciated.
I have the wrong name on my migration. I can see it doesn't follow the naming convention, but I'm not sure how the names are generated.