Added @tryghost/metrics-server as a dependency #21329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we need this to happen before running the setup script because TS dependencies won't be compiled at this point
) closes TryGhost#16748 The members/:member_id/signin_urls endpoint currently only does cookie-based authentication. When TryGhost#21249 is merged, turning on 2FA is going to break any 3rd party processes that use it (including my social sign-in offering). This patch gives admin API keys 'read' permission on this endpoint, and enables 3rd party processes to handle user logins the right way, instead of via a staff member's email/password. Migration included. Feedback appreciated. I have the wrong name on my migration. I can see it doesn't follow the naming convention, but I'm not sure how the names are generated. --------- Co-authored-by: Michael Barrett <[email protected]>
…#19676) - this helps catch test failures that are due to us writing timezone dependent code Co-authored-by: Daniel Lockyer <[email protected]>
no ref Stubbed expected test errors. In general, we should be expecting these errors in the tests as we write them as that is the expected behavior (or that behavior should change).
…host#21325) no ref When running tests, occasionally we'll see some varying sort in the members api response because members are generally all created with the same timestamp. While `ObjectId` should be progressive, and our defalut sort is `ORDER BY created_at desc, id desc`, we still would sometimes see issues. This ought to remove any flakiness.
ref https://linear.app/tryghost/issue/ONC-387/ With some recent changes, we added validation to unsubscribe URLs to verify the source, allowing us to cut down on spam and improving security, as the underlying key could be re-generated should the need arise. This had the side effect of making unsubscribe URLs difficult to reconstruct when using third-party/downstream integrations, such as ActiveCampaign, which fills a gap in the current Ghost feature set. Now any authenticated query to `/api/members` will return an `unsubscribe_url` field that can be used directly.
github-actions
bot
added
the
migration
|
It looks like this PR contains a migration 👀 General requirements
Schema changes
Data changes
|
cmraible
changed the title
|
Somehow branch got messed up, closing in favor of #21330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
@tryghost/metrics-serveras a dependency toghost/core/package.json. It worked in most cases as a 'Ghost dependency' — yarn installs all node_modules in a flat structure, so even though it wasn't a dependency in package.json, it still resolved to the correct package, as long as the typescript packages were all built first.ts:buildon all packages before running tests, and it worked in production because we build the TS packages as part of the docker build. However, when trying to run tests locally, it would sometimes fail unless you explicitly rannx run-many -t build:tsat the top level before running the tests.package.jsonfixes this problem.