Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass 2FA for accounts which haven't yet logged in #21725

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

sam-lord
Copy link
Contributor

ref ENG-1681

@sam-lord sam-lord self-assigned this Nov 26, 2024
@github-actions github-actions bot added the migration [pull request] Includes migration for review label Nov 26, 2024
Copy link
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@sam-lord
Copy link
Contributor Author

Schema changes noted here are just a comment addition, so not actually a reason to change this to a minor release

@sam-lord sam-lord merged commit 28dba53 into main Nov 26, 2024
21 checks passed
@sam-lord sam-lord deleted the 2fa-setup-fix branch November 26, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration [pull request] Includes migration for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant