Skip to content
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.

Separate track made good and heading #272

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Separate track made good and heading #272

wants to merge 5 commits into from

Conversation

patrick-5546
Copy link
Member

Resolves #267

@patrick-5546 patrick-5546 requested a review from tylerlum December 6, 2021 00:48
@patrick-5546
Copy link
Member Author

I noticed that the boat often sails up current in this run:

roslaunch local_pathfinding all.launch speedup:=100 ocean_current_speed:=5

Is this to be expected? Does our pathfinding cost function take into account ocean current?

@patrick-5546
Copy link
Member Author

patrick-5546 commented Dec 6, 2021 •
edited
Loading

Todo

@tylerlum
Copy link
Contributor

Future PR: Consider AIS boats' track_made_good vs heading (which one to use?)

@patrick-5546
Copy link
Member Author

Once this is merged in to master, the other CI tests should pass

jamenkaye
jamenkaye approved these changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@jamenkaye jamenkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked on my computer :)

@patrick-5546
Copy link
Member Author

Future PR: Consider AIS boats' track_made_good vs heading (which one to use?)

Related issue: #265

@patrick-5546 patrick-5546 mentioned this pull request Jan 15, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamenkaye jamenkaye jamenkaye approved these changes

@tylerlum tylerlum Awaiting requested review from tylerlum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Break apart track_made_good and true_heading
3 participants
@patrick-5546 @tylerlum @jamenkaye