Skip to content

Commit

Permalink
update Dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
hkbu-kennycheng committed Oct 31, 2024
1 parent 4125f0a commit a654aa7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
ARG EXPRESS_REPO
FROM node:current-alpine AS build

COPY . /app
WORKDIR /app

RUN npm install && npm run build

ARG EXPRESS_REPO
FROM ${EXPRESS_REPO}

Check warning on line 9 in Dockerfile

View workflow job for this annotation

GitHub Actions / pack

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG ${EXPRESS_REPO} results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

COPY --from=build /app/dist /app/public
Expand Down

0 comments on commit a654aa7

Please sign in to comment.