Old code and update error messages

stglib/core/qaqc.py

@@ -406,8 +406,8 @@ def trim_std_ratio(ds, var):
             ds = utils.insert_note(ds, var, notetxt)
 
         else:
-            print(
-                f"{var}_std does not exist was NOT able to trim using standard deviation ratio method"
+            raise ValueError(
+                f"User specified {ds.attrs[var + '_std_ratio']=} but {var}_std does not exist. Was not able to trim using standard deviation ratio method"
             )
 
     return ds
@@ -416,9 +416,7 @@ def trim_std_ratio(ds, var):
 def trim_warmup(ds, var):
     if var + "_warmup_samples" in ds.attrs:
         if "sample" in ds[var].coords:
-            print(ds[var])
             ds[var] = ds[var].where(ds["sample"] > ds.attrs[var + "_warmup_samples"])
-            print(ds[var])
             notetxt = f"Removed {ds.attrs[var + '_warmup_samples']} samples at the beginning of each burst. "
 
             ds = utils.insert_note(ds, var, notetxt)

stglib/core/runcmd.py

@@ -13,12 +13,15 @@ def get_metadata(args):
     with open(args.config) as f:
         config = yaml.safe_load(f)
 
-    for k in config:
-        if k in metadata:
-            warnings.warn(
-                f"attrs collision. Replacing '{k}={metadata[k]}' from global attributes file with '{k}={config[k]}' from YAML config file."
-            )
-        metadata[k] = config[k]
+    try:
+        for k in config:
+            if k in metadata:
+                warnings.warn(
+                    f"attrs collision. Replacing '{k}={metadata[k]}' from global attributes file with '{k}={config[k]}' from YAML config file."
+                )
+            metadata[k] = config[k]
+    except TypeError:
+        raise TypeError(f"Could not load metadata from {args.config}")
 
     return metadata
 

stglib/rsk/cdf2nc.py

@@ -262,7 +262,7 @@ def ds_add_attrs(ds):
         if utils.check_time_fits_in_int32(ds, "time"):
             ds["time"].encoding["dtype"] = "i4"
         else:
-            print("Casting time to double")
+            print("time variable will not fit in int32; casting to double")
             ds["time"].encoding["dtype"] = "double"
     else:
         if utils.check_time_fits_in_int32(ds, "time"):