Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lowell Tilt Current Meter (TCM) support #184

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

ssuttles-usgs
Copy link
Collaborator

Add support to process Lowell Tilt Current Meters. New tcm.py module created to process current data, tests, and documentation have been updated. Added LFS tracking for files in tests/data folder.

@dnowacki-usgs
Copy link
Member

Thanks Steve! I'm wondering why for this instrument we are publishing speed and direction when for most other instruments we only publish east and north components. Also, if we do indeed want to publish spd/dir, it looks like speed and direction are already provided by the file. Why recompute it?

@ssuttles-usgs
Copy link
Collaborator Author

Hey Dan, Welcome back! I anticipated the first question. main reason that speed and direction are included is the instrument software includes it, as you point out, and I thought some users might want/expect it. I went back and forth on that one. The reason for recalculating speed and direction is because need to apply the magnetic variation. I guess I could have just adjusted the direction for it, but I decided to find from east and north after being rotated for magnetic variation.

@dnowacki-usgs dnowacki-usgs merged commit c747a7a into USGS-CMG:master Feb 12, 2024
11 checks passed
@ssuttles-usgs ssuttles-usgs deleted the addtcm branch November 19, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants