Handle Vector continuous data and improve coordinate transforms #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey Bo, thanks very much for this PR. This will be a great addition. I have several small requests and also some larger questions, particularly regarding the new coordinate transformation stuff. I think it might be easiest to talk this over in a call sometime.
dnowacki-usgs
changed the title
* Linter * code style * Update waves docs * Fix # values affected text to account for NaN * Remove rdradcp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added the ability to process continuous vector data.
-Updated velocity transformations using numpy.einsum.
-Includes using all available SEN data, instead of first sample for entire burst.
What still needs to be done (in another pull request):
-Adding the ability to process IMU vec data
-Adding the ability to reshape continuous vec data for wave stats.