Repository navigation
Conversation
min-deps-ci.yml and upstream-dev-ci.yml had no permissions block, so every job got the repo default, which is read/write. Only failure-issue writes, and only to issues. contents: read at the top level, issues: write on failure-issue. Matches what asv-benchmarking-pr.yml already does. Closes #1819
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1819. Follow-up from #1816.
Overview
min-deps-ci.ymlandupstream-dev-ci.ymlhad nopermissions:block, so every job got the repo default, which is read/write. The test jobs — the ones running old or unreleased third-party packages — do not write anything. Onlyfailure-issuedoes, and only to issues.This adds
contents: readat the top of each workflow andissues: writeonfailure-issue. Same patternasv-benchmarking-pr.ymlalready uses.Nothing else changes.
failure-issueonly callsgh issue list / edit / create, which needissues, andactions/checkoutneedscontents: read; both are granted.PR Checklist
General
Testing & Benchmarking
Documentation and Examples
AI Disclosure
AI Usage: Claude