Spearbit Gas-02: Optimize tickSpacingToMaxLiquidityPerTick (#823)

Spearbit Gas-02
Uniswap · Aug 27, 2024 · 0fc5a0b · 0fc5a0b
1 parent 9325e94
commit 0fc5a0b
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 14 deletions.
diff --git a/.forge-snapshots/add liquidity to already existing position with salt.snap b/.forge-snapshots/add liquidity to already existing position with salt.snap
@@ -1 +1 @@
-144677
+144656
diff --git a/.forge-snapshots/addLiquidity CA fee.snap b/.forge-snapshots/addLiquidity CA fee.snap
@@ -1 +1 @@
-170867
+170846
diff --git a/.forge-snapshots/addLiquidity with empty hook.snap b/.forge-snapshots/addLiquidity with empty hook.snap
@@ -1 +1 @@
-274028
+274007
diff --git a/.forge-snapshots/addLiquidity with native token.snap b/.forge-snapshots/addLiquidity with native token.snap
@@ -1 +1 @@
-135144
+135123
diff --git a/.forge-snapshots/create new liquidity to a position with salt.snap b/.forge-snapshots/create new liquidity to a position with salt.snap
@@ -1 +1 @@
-292854
+292833
diff --git a/.forge-snapshots/poolManager bytecode size.snap b/.forge-snapshots/poolManager bytecode size.snap
@@ -1 +1 @@
-24273
+24268
diff --git a/.forge-snapshots/simple addLiquidity second addition same range.snap b/.forge-snapshots/simple addLiquidity second addition same range.snap
@@ -1 +1 @@
-98882
+98861
diff --git a/.forge-snapshots/simple addLiquidity.snap b/.forge-snapshots/simple addLiquidity.snap
@@ -1 +1 @@
-161406
+161385
diff --git a/src/libraries/Pool.sol b/src/libraries/Pool.sol
@@ -550,18 +550,18 @@ library Pool {
     /// @return result The max liquidity per tick
     function tickSpacingToMaxLiquidityPerTick(int24 tickSpacing) internal pure returns (uint128 result) {
         // Equivalent to:
-        // int24 minTick = (TickMath.MIN_TICK / tickSpacing) * tickSpacing;
-        // int24 maxTick = (TickMath.MAX_TICK / tickSpacing) * tickSpacing;
-        // uint24 numTicks = uint24((maxTick - minTick) / tickSpacing) + 1;
+        // int24 minTick = (TickMath.MIN_TICK / tickSpacing);
+        // int24 maxTick = (TickMath.MAX_TICK / tickSpacing);
+        // uint24 numTicks = maxTick - minTick + 1;
         // return type(uint128).max / numTicks;
         int24 MAX_TICK = TickMath.MAX_TICK;
         int24 MIN_TICK = TickMath.MIN_TICK;
         // tick spacing will never be 0 since TickMath.MIN_TICK_SPACING is 1
         assembly ("memory-safe") {
             tickSpacing := signextend(2, tickSpacing)
-            let minTick := mul(sdiv(MIN_TICK, tickSpacing), tickSpacing)
-            let maxTick := mul(sdiv(MAX_TICK, tickSpacing), tickSpacing)
-            let numTicks := add(sdiv(sub(maxTick, minTick), tickSpacing), 1)
+            let minTick := sdiv(MIN_TICK, tickSpacing)
+            let maxTick := sdiv(MAX_TICK, tickSpacing)
+            let numTicks := add(sub(maxTick, minTick), 1)
             result := div(sub(shl(128, 1), 1), numTicks)
         }
     }