add getPoolState method to the StateLibrary #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyek
force-pushed
the
add-pool-state-extsload
branch
from
498b540 to
27aa510
Compare
xyek
force-pushed
the
add-pool-state-extsload
branch
from
27aa510 to
677adce
Compare
hensha256
requested changes
Aug 30, 2024
| StateLibrary.getPoolState(manager, poolId); | ||
| snapLastCall("extsload getPoolState"); | ||
|
|
||
| assertEq(slot0.sqrtPriceX96(), 78680104762184586858280382455); |
There was a problem hiding this comment.
can you instead test these against getSlot0?
| returns (Slot0 slot0, uint256 feeGrowthGlobal0X128, uint256 feeGrowthGlobal1X128, uint128 liquidity) | ||
| { | ||
| bytes32 stateSlot = _getPoolStateSlot(poolId); | ||
| bytes memory data = manager.extsload(stateSlot, 4); |
There was a problem hiding this comment.
this needs to be updated to an array of bytes32 that gets returned
| slot0 := mload(add(data, 32)) | ||
| feeGrowthGlobal0X128 := mload(add(data, 64)) | ||
| feeGrowthGlobal1X128 := mload(add(data, 96)) | ||
| liquidity := mload(add(data, 128)) |
There was a problem hiding this comment.
needs to be masked to remove the other 128 bits of data from this data type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This util is helpful when someone wants to read all the global pool state. It is better than making multiple extsload calls.