Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable force mode compatibility with various move types #230

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

urrsk
Copy link
Member

@urrsk urrsk commented Dec 10, 2024

This should make force mode work with various of move types.
With this commit, the joint positions used for checks and interpolations is now done without force mode modifies.

This commit relates to #138

@urrsk urrsk requested a review from urfeex December 10, 2024 10:14
The joint positions used for checks and interpolations needs
to be without force mode modifies.
@urfeex urfeex force-pushed the force_mode_get_joint_angles branch from 3b0809b to 3a6d34e Compare December 17, 2024 08:35
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.82%. Comparing base (cf30c14) to head (3a6d34e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   71.79%   71.82%   +0.03%     
==========================================
  Files          71       71              
  Lines        2783     2783              
  Branches      351      351              
==========================================
+ Hits         1998     1999       +1     
  Misses        594      594              
+ Partials      191      190       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does make sense and I manually checked that it works as expected.

@urfeex urfeex merged commit 2c12bee into UniversalRobots:master Dec 17, 2024
23 of 25 checks passed
@urrsk urrsk deleted the force_mode_get_joint_angles branch December 17, 2024 14:08
urfeex pushed a commit to urfeex/Universal_Robots_Client_Library that referenced this pull request Jan 10, 2025
…ots#230)

This should make force mode work with various of move types. 
With this commit, the joint positions used for checks and interpolations
is now done without force mode modifications.

When the robot is in an offset situation, where the robot isn't at the position that
is currently used for motion commands, this will use the non-offset position to
check whether a new motion is within the reachable limits of the robot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants