Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed normalize_joint_error_ to joints_angle_wraparound_ #876

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Nov 14, 2023

This will be broken soon in ros-controls/ros2_controllers#834

@fmauch fmauch marked this pull request as ready for review November 15, 2023 18:39
This has been renamed to read_state_from_state_interfaces
Copy link
Contributor

@t-schnell t-schnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good an quite necessary to me - renames are correct and seem to be merged for a week in ros2_controllers.

Copy link
Contributor

@RobertWilbrandt RobertWilbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, good to have this updated. For future reference: ros-controls/ros2_controllers#797 for the second rename.

@RobertWilbrandt RobertWilbrandt merged commit d77db83 into UniversalRobots:main Nov 21, 2023
4 of 7 checks passed
@fmauch fmauch deleted the update_jtc_api branch November 21, 2023 19:07
@RobertWilbrandt
Copy link
Contributor

This needs to be backported to iron after ros-controls/ros2_controllers#869

@Mergifyio backport iron

@RobertWilbrandt
Copy link
Contributor

@Mergifyio backport iron

Copy link

mergify bot commented Nov 30, 2023

backport iron

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants