MessageLogger: Fix message history loss on reconnect + unloaded channels - #4612
Open
reservedbytes wants to merge 2 commits into
Open
reservedbytes wants to merge 2 commits into
reservedbytes wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your Changes
I noticed that if someone sent me a message and then deleted it, the logger didn´t log it at all, after some reverse engineering (which also made me find another problem included in this PR which is losing messages after a reconnect), I found out that Discord only stores messages for channels that are ready.
Because my account is in ~150 servers, it was giving me an average of ~0.25 messages per second, to prevent the plugin from eating the memory very quickly with loads of unwanted modified/deleted messages, I made a simple memory filter for DMs and servers where you´ve opened any channel in the current session.
Screenshots (if applicable)
Not applicable
Checklist before submitting