Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JitPack, Loom 1.9 #664

Closed
wants to merge 1 commit into from
Closed

Update JitPack, Loom 1.9 #664

wants to merge 1 commit into from

Conversation

Kichura
Copy link
Member

@Kichura Kichura commented Dec 24, 2024

  1. Update JDK to 21.0.5 in JitPack,
  2. Updates Fabric Loom to 1.9+ to address Gradle-related issues in terms of building.

@Kichura Kichura added the dependencies Pull requests that update a dependency file label Dec 24, 2024
@FlorianMichael
Copy link
Member

The main branch is freezed at the moment in favour of the v4.0.0 branch.

@Kichura
Copy link
Member Author

Kichura commented Dec 25, 2024

Cancelling my issue then as loom is already up-to-date tho jitpack isn't but do whatever with it.

@Kichura Kichura closed this Dec 25, 2024
@FlorianMichael
Copy link
Member

I planned on removing jitpack soon as it won't work with the new project structure + we have our own repository server.

@Kichura
Copy link
Member Author

Kichura commented Dec 25, 2024

is it the Jenkins Server or what's the source of it?

@FlorianMichael
Copy link
Member

As far as I know, jitpack doesn't support multi project builds, meaning people won't be able to include viafabricplus-api which will exist after v4. Ideally they should use https://repo.viaversion.com/#/ then

@Kichura
Copy link
Member Author

Kichura commented Dec 25, 2024

Will plan on discontinuing it in baseproject then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kichura @FlorianMichael