Repository navigation
coop-threads: Handle thread creation failure - #896
Merged
Merged
Conversation
This commit is an adjustment to `pthread_create` on wasip3 with coop threads enabled, specifically to account for WebAssembly/component-model#760 where `thread.new-indirect` may fail. The handling of errors here was also adjusted where -1 is now the only failure code recognized from `thread.new-indirect` and limiting the bounds of the created thread tid is validated only in successful spawns. Additionally the return value isn't returned directly from the function, but instead the `EAGAIN` symbolic constant is returned.
dicej
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is an adjustment to
pthread_createon wasip3 with coop threads enabled, specifically to account forWebAssembly/component-model#760 where
thread.new-indirectmay fail. The handling of errors here was also adjusted where -1 is now the only failure code recognized fromthread.new-indirectand limiting the bounds of the created thread tid is validated only in successful spawns. Additionally the return value isn't returned directly from the function, but instead theEAGAINsymbolic constant is returned.