Skip to content

Add details parameter to conditionally display grouped benchmarks - #157

Merged
camillobruni merged 12 commits into
WebKit:mainfrom
camillobruni:2025-08-20_ungroup
Oct 1, 2025
Merged

camillobruni merged 12 commits into
WebKit:mainfrom
camillobruni:2025-08-20_ungroup

Conversation

@camillobruni

Copy link
Copy Markdown
Contributor

This is quite nice for debugging.

@netlify

netlify Bot commented Aug 20, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit f5e0819
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68dd7fe2dbb3330008e01fca
😎 Deploy Preview https://deploy-preview-157--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni

Copy link
Copy Markdown
Contributor Author
Screenshot 2025-08-20 at 14 00 47

@camillobruni
camillobruni requested a review from kmiller68 August 20, 2025 15:51
@camillobruni
camillobruni requested a review from danleh September 2, 2025 07:45

@danleh danleh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

Comment thread JetStreamDriver.js Resolved
Comment thread JetStreamDriver.js Resolved
Comment thread JetStreamDriver.js Resolved
Comment thread cli.js Resolved

@danleh danleh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM with another round of nits.

Comment thread JetStreamDriver.js Resolved
Comment thread JetStreamDriver.js Resolved
Comment thread JetStreamDriver.js Resolved
@camillobruni
camillobruni merged commit c432b1a into WebKit:main Oct 1, 2025
9 of 10 checks passed
@camillobruni
camillobruni deleted the 2025-08-20_ungroup branch October 1, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants