Skip to content

render non default params - #197

Merged
camillobruni merged 8 commits into
WebKit:mainfrom
camillobruni:2025-10-13_bg_color
Oct 23, 2025
Merged

camillobruni merged 8 commits into
WebKit:mainfrom
camillobruni:2025-10-13_bg_color

Conversation

@camillobruni

Copy link
Copy Markdown
Contributor

With non-default params:

  • Add red-ish background gradient
  • Hide jetstream description
  • List changed params in table
Screenshot 2025-10-13 at 13 06 01

@netlify

netlify Bot commented Oct 13, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit e656f5f
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68f8fd01e5504f0008d1049a
😎 Deploy Preview https://deploy-preview-197--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni
camillobruni requested review from danleh and kmiller68 and removed request for kmiller68 October 17, 2025 13:34

@danleh danleh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite sure what the issue is, but when I run the preview with e.g. ?testList=zlib-wasm (https://deploy-preview-197--webkit-jetstream-preview.netlify.app/?testList=zlib-wasm), I get the "Non-standard Parameters" warning and red background, but all tests are run and the value of testList is not shown.
image

Comment thread JetStream.css Resolved
@camillobruni

Copy link
Copy Markdown
Contributor Author
  • Added params tests
  • Added "testList" to the list of accepted source params for consistency
  • Fixed nonDefaultParams extraction for testList arrays
  • Used a slightly less aggressive hue settings, I think this looks now pretty neat
Screenshot 2025-10-22 at 11 08 52

@danleh danleh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but with some questions.

Comment thread tests/unit-tests.js Resolved
Comment thread params.js Resolved
Comment thread params.js Resolved
Comment thread index.html Resolved

@kmiller68 kmiller68 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM too. We could change the color of the button as @danleh mentioned but I'm open.

Comment thread tests/unit-tests.js Resolved
Comment thread params.js Resolved
@camillobruni

Copy link
Copy Markdown
Contributor Author

Applied a hue-rotate to the full body:

Screenshot 2025-10-22 at 17 48 48

@camillobruni
camillobruni merged commit 1323068 into WebKit:main Oct 23, 2025
9 of 10 checks passed
@camillobruni
camillobruni deleted the 2025-10-13_bg_color branch October 23, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants