Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to modbus disconnect #723

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Updates to modbus disconnect #723

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c4a509
Sleep for 1 second on disconnect
WillCodeForCats Jan 4, 2025
7752279
Catch exceptions from close()
WillCodeForCats Jan 4, 2025
d303c72
Delete client object on clear
WillCodeForCats Jan 4, 2025
e4f5faf
Update hub.py
WillCodeForCats Jan 4, 2025
617c911
Update hub.py
WillCodeForCats Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions custom_components/solaredge_modbus_multi/hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from homeassistant.helpers.entity import DeviceInfo
from pymodbus.client import AsyncModbusTcpClient
from pymodbus.constants import Endian
from pymodbus.exceptions import ConnectionException, ModbusIOException
from pymodbus.exceptions import ConnectionException, ModbusException, ModbusIOException
from pymodbus.payload import BinaryPayloadDecoder
from pymodbus.pdu import ExceptionResponse

Expand Down Expand Up @@ -483,11 +483,18 @@ def disconnect(self, clear_client: bool = False) -> None:
f"(clear_client={clear_client})."
)
)
self._client.close()

try:
self._client.close()
except ModbusException as e:
_LOGGER.error(f"ModbusException on close: {e}")

if clear_client:
del self._client
self._client = None

await asyncio.sleep(1)

async def shutdown(self) -> None:
"""Shut down the hub and disconnect."""

Expand Down
Loading