Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Block Inserter Search Infinity Spinner #68600

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Vrishabhsk
Copy link
Contributor

What?

Why?

  • When the user is offline, the search prodiuces a 500 error code, the Infinity Spinner is not hidden
  • The Spinner should be hidden once the request fails, and should render the relevant placeholder

How?

  • Return empty array in the place of blocks in the error part of the trycatch block

Screenshots or screencast

Before After
Screenshot 2025-01-10 at 5 30 28 PM Screenshot 2025-01-10 at 5 27 54 PM

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Vrishabhsk <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant