Repository navigation
Build/Test Tools: Update to Ubuntu 26.04, pin the Windows and macOS runners, and update Playwright to 1.64.1 in the 6.4 branch. - #15564
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This updates the GitHub-hosted Ubuntu runners used in GitHub Actions workflows to `ubuntu-26.04`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Y86gzNmrCaBaUCqQTNKYH
Update `@playwright/test` from `1.49.1` to `1.64.1`, along with its `playwright` and `playwright-core` dependencies. Playwright 1.61.0 is the first version that supports Ubuntu 26.04. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Y86gzNmrCaBaUCqQTNKYH
This replaces `windows-latest` with `windows-2025` and `macos-latest` with `macos-15`, matching trunk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Y86gzNmrCaBaUCqQTNKYH
7f19aef to
cd78060
Compare
lancewillett
left a comment
There was a problem hiding this comment.
Checked against the branch's workflows: every ubuntu-latest label is now ubuntu-26.04, Windows and macOS are pinned to windows-2025 and macos-15 as in #15518, and Playwright is 1.64.1 (the branch is on Node 20, which it needs). CI is green (50 passed, 14 skipped). Reusable workflows on this branch run from trunk, so the jobs that use them still ran on ubuntu-24.04 here. Please land #15518 first, then this.
AI review · claude-opus-5-5
Backport of the runner update in #15518 to the
6.4branch.Changes
ubuntu-latesttoubuntu-26.04, matching trunk. GitHub is movingubuntu-latestfrom 24.04 to 26.04 between 2026-10-19 and 2026-11-19.windows-latesttowindows-2025andmacos-latesttomacos-15, matching trunk, in a separate commit.windows-latestalready points towindows-2025, so the Windows jobs are unchanged.macos-latestcurrently points tomacos-26, so the macOS jobs move to the version used by trunk and 6.8+.@playwright/testfrom1.49.1to1.64.1, matching trunk. 1.49.1 still works on Ubuntu 26.04 (it falls back to the 24.04 browser build), so this is not required on this branch. It keeps a single Playwright version across trunk and all branches that use it.The Playwright changes are in their own commit so they can be reviewed separately.
Playwright 1.49.1 → 1.64.1 review
@playwright/test,playwrightand theplaywright-corecopy nested underplaywrightchange, each to 1.64.1. Nothing else moves.@wordpress/scripts26.13.13 still depends directly onplaywright-core1.32.0.wp-scripts test-playwrightonly uses that copy to install browsers before the run; the tests run on 1.64.1. This was already the case with 1.49.1, so it isn't a regression.playwright test --listfinds the same tests before and after: e2e 20, performance 40, visual-regression 22.@wordpress/e2e-test-utils-playwright0.10.13.>=20, and this branch uses Node 20.screenfromdevices['Desktop Chrome']in the@wordpress/scriptsbase config, and 1.57 switched Chromium to Chrome for Testing builds. Either could changetoHaveScreenshotoutput, but the visual regression suite isn't run in CI and has no committed baselines. If the oldscreenbehaviour is needed, addscreen: undefinedto the config'suse.Trac ticket: Core-66499
Use of AI Tools
Claude Code (Claude Opus 5.5) made these changes, reviewed the Playwright update, ran the fork-based test runs, and drafted this description. Draft PRs should be considered unverified and unreviewed by a human.
🤖 Generated with Claude Code