Rewrote fileToUint8Array function to be also NodeJS/Deno compatible. #2117
+5
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Performing multipart upload and posting of data currently works on the web (client) side. Doing it on PHP WASM instance running on NodeJS or other server runtimes (except Deno) causes this issue due to FileReader not supported on the runtime:
Implementation details
This PR introduces an alternative to using FileReader in order to determine the
Uint8Array
value for aFile
instance. This is creating a new instance ofUint8Array
from the file's buffer instead.File
's arrayBuffer instance method and Uint8Array class are both supported on NodeJS and Deno, and as well as on most recent browsers.Testing Instructions (or ideally a Blueprint)
npm run test