WIP - Lighthouse checks #47
Conversation
…o us because we need it to play nicely with Netlify. More details in PR.
| - npm run build | ||
| env: | ||
| matrix: | ||
| secure: RBUY+C7OegZoLEAv0ukvFZlVQUN3PIHpNDiguJj66bBWVid8XHYRVLkmyxvN79VwR8zb5VPZmOHtFOnm6z5+AL9uCT/FEPBCJJ/uoglIszq1EW3zxv4pWRplrF25yM25QzfjmC9wy3GhQvpd9+OGDWPnXS0b2PjU2iC8Z+trJquXjN+maQ819cpeCAiw+gkmXhDWts/xSZK/OH2QhaEzhU1GBieFs8/mfhVIH84F3mPFPdoyoKsQqgwB1FK5FBCTvVAAkpjJnsbq2OZQebIWonrt5lplmGMxbNmh4xZpVffdMIJzSdr2l7sjrYpTjZkTvSOz+3vq7T1zK8+gn2Swpi0U1AZ18746QxUrPqfcuYxBk5BWnbHqYrjb28xVmAHen4jouUzT99g6tB1GMKmXNMMC2ey8WsxgBfh+JgOXhnzANOfTNZo0RMV/z0OZJp19LrFgfzvpmqiIdtraErT3ZpkJaIpNJaBZAOeqLvoBVdSeKDBtscPleW7HOMtteltFcN0l2l6R0fdl7gwkjvP1BP+sc0lFOEmzhzq16O736UeW8JfwbEGHyUXWkrnsC6pfsMhgQp4UBnclOlkMuCDSAZXlypY39vPMY1FNAAZGk6gce1kO132NBy2CWkt+Ibk/r+mXUsub2cVjBpAhtVKOvdGsbjOXzEm3eU29EXeWZZs= |
There was a problem hiding this comment.
Two small blocking comments here:
- Can you add a comment saying something like "this is the encrypted
LIGHTHOUSE_API_KEY" - Add add it to
env: global:rather thanenv: matrix
|
So we currently deploy PR builds via Netlify. So the key here isn't to add a |
|
I'm gonna figure out the deploy script stuff (hopefully soon ^^) so I'm assigning myself to this issue |
|
Hi friends <3 I can't find the space in my well of motivation to help with this particular PR - setup for nodejs apps is just a bit too far out of my comfort zone 🙏🏼 |
|
@halfghaninne I'm going to close this for now. Lighthouse is not a priority, but I think we can refer to this PR and re-open if and when someone has the bandwidth or interest to continue with it. |
Closes #6
Requested feedback
We're a bit stuck on Step 2 of the Lighthouse set up process.
Netlify is currently configuring to run on our repo in the Netlify admin GUI, but Lighthouse Bot wants us to trigger a deploy using a
./deploy.shexecutable.How do we configure Lighthouse to run in the Netlify staging environment?
Relevant docs/conversation:
Official Netlify build settings docs:
Conversation between some devs trying to do something similar: