Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Lighthouse checks #47

Closed
wants to merge 2 commits into from
Closed

WIP - Lighthouse checks #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28cd6b0
adds lighthouse api key to travis config
halfghaninne May 18, 2019
cdfbdf2
wip - what would go in this deploy executable is a bit of a mystery t…
halfghaninne May 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
language: node_js
node_js:
- '10.15.3'

- 10.15.3
script:
# the `audit-level` is at `moderate` to avoid https://www.npmjs.com/advisories/836, which has no resolution at time of writing
# consider swapping from `moderate` to `low` whenever this is possible and / reasonable (ex: when issue in the link above is fixed)
- npm audit --audit-level=moderate
- npm run flow
- npm run prettier
- npm run build
- npm audit --audit-level=moderate
- npm run flow
- npm run prettier
- npm run build
env:
matrix:
secure: RBUY+C7OegZoLEAv0ukvFZlVQUN3PIHpNDiguJj66bBWVid8XHYRVLkmyxvN79VwR8zb5VPZmOHtFOnm6z5+AL9uCT/FEPBCJJ/uoglIszq1EW3zxv4pWRplrF25yM25QzfjmC9wy3GhQvpd9+OGDWPnXS0b2PjU2iC8Z+trJquXjN+maQ819cpeCAiw+gkmXhDWts/xSZK/OH2QhaEzhU1GBieFs8/mfhVIH84F3mPFPdoyoKsQqgwB1FK5FBCTvVAAkpjJnsbq2OZQebIWonrt5lplmGMxbNmh4xZpVffdMIJzSdr2l7sjrYpTjZkTvSOz+3vq7T1zK8+gn2Swpi0U1AZ18746QxUrPqfcuYxBk5BWnbHqYrjb28xVmAHen4jouUzT99g6tB1GMKmXNMMC2ey8WsxgBfh+JgOXhnzANOfTNZo0RMV/z0OZJp19LrFgfzvpmqiIdtraErT3ZpkJaIpNJaBZAOeqLvoBVdSeKDBtscPleW7HOMtteltFcN0l2l6R0fdl7gwkjvP1BP+sc0lFOEmzhzq16O736UeW8JfwbEGHyUXWkrnsC6pfsMhgQp4UBnclOlkMuCDSAZXlypY39vPMY1FNAAZGk6gce1kO132NBy2CWkt+Ibk/r+mXUsub2cVjBpAhtVKOvdGsbjOXzEm3eU29EXeWZZs=
Copy link
Member

@coilysiren coilysiren May 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small blocking comments here:

  • Can you add a comment saying something like "this is the encrypted LIGHTHOUSE_API_KEY"
  • Add add it to env: global: rather than env: matrix

after_success:
- ./deploy.sh