Merge pull request #21953 from Yoast/496-ai-optimize-make-highlightin…

…g-and-ai-button-work-for-sentence-length-assessment-after-ai-suggestion-is-applied

Updates the readability analysis when the client IDs of the blocks change

packages/yoastseo/spec/worker/AnalysisWebWorkerSpec.js

@@ -1792,6 +1792,19 @@ describe( "AnalysisWebWorker", () => {
 			worker._paper = new Paper( "This is the content.", { keyword: "dogs" } );
 			expect( worker.shouldReadabilityUpdate( paper ) ).toBe( true );
 		} );
+
+		test( "returns true when the client IDs of the blocks inside attributes changes", () => {
+			const paper = new Paper( "This is the content.", { wpBlocks: [
+				{ name: "block1", clientId: "1234" },
+				{ name: "block2", clientId: "5678" },
+			] } );
+
+			worker._paper = new Paper( "This is the content.", { wpBlocks: [
+				{ name: "block1", clientId: "6783" },
+				{ name: "block2", clientId: "0636" },
+			] } );
+			expect( worker.shouldReadabilityUpdate( paper ) ).toBe( true );
+		} );
 	} );
 
 	describe( "shouldSeoUpdate", () => {

packages/yoastseo/src/worker/AnalysisWebWorker.js

@@ -2,7 +2,7 @@
 // External dependencies.
 import { enableFeatures } from "@yoast/feature-flag";
 import { __, setLocaleData, sprintf } from "@wordpress/i18n";
-import { forEach, has, includes, isEmpty, isNull, isObject, isString, isUndefined, merge, pickBy } from "lodash";
+import { forEach, has, includes, isEmpty, isEqual, isNull, isObject, isString, isUndefined, merge, pickBy } from "lodash";
 import { getLogger } from "loglevel";
 
 // Internal dependencies.
@@ -954,6 +954,12 @@ export default class AnalysisWebWorker {
 			return true;
 		}
 
+		// Perform deep comparison between the list of Gutenberg blocks as we want to update the readability analysis
+		// if the client IDs of the blocks inside `wpBlocks` change.
+		if ( ! isEqual( this._paper._attributes.wpBlocks, paper._attributes.wpBlocks ) ) {
+			return true;
+		}
+
 		return this._paper.getLocale() !== paper.getLocale();
 	}