Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor neighbors-based metrics to use NeighborsResults #129

Merged
merged 24 commits into from
Jan 4, 2024

fix lisi

a22c3e7
Select commit
Loading
Failed to load commit list.
Merged

Refactor neighbors-based metrics to use NeighborsResults #129

fix lisi
a22c3e7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 4, 2024 in 0s

91.00% (target 1.00%)

View this Pull Request on Codecov

91.00% (target 1.00%)

Details

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9bd6efb) 93.77% compared to head (a22c3e7) 91.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   93.77%   91.00%   -2.77%     
==========================================
  Files          25       25              
  Lines         931      956      +25     
==========================================
- Hits          873      870       -3     
- Misses         58       86      +28     
Files Coverage Δ
src/scib_metrics/_graph_connectivity.py 100.00% <100.00%> (ø)
src/scib_metrics/_lisi.py 100.00% <100.00%> (ø)
src/scib_metrics/benchmark/_core.py 98.60% <100.00%> (-0.03%) ⬇️
src/scib_metrics/nearest_neighbors/__init__.py 100.00% <100.00%> (ø)
src/scib_metrics/nearest_neighbors/_jax.py 100.00% <100.00%> (ø)
src/scib_metrics/nearest_neighbors/_pynndescent.py 100.00% <100.00%> (ø)
src/scib_metrics/utils/_diffusion_nn.py 80.76% <100.00%> (-11.69%) ⬇️
src/scib_metrics/utils/_lisi.py 100.00% <100.00%> (ø)
src/scib_metrics/utils/_pcr.py 92.59% <100.00%> (-0.75%) ⬇️
src/scib_metrics/_nmi_ari.py 93.87% <88.88%> (+0.12%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes