Fix for issue where statuscode 255 was being returned even for succes…

…sful transactions (#2125) - `receipt.accepted==Some(false)` is no ignored, and if `receipt.success==true` the transaction is reported dispatched Co-authored-by: Saeed Dadkhah <[email protected]>
Zilliqa · Jan 13, 2025 · abb7cad · abb7cad
1 parent 0add167
commit abb7cad
Showing 1 changed file with 19 additions and 18 deletions.
diff --git a/zilliqa/src/api/types/zil.rs b/zilliqa/src/api/types/zil.rs
@@ -800,25 +800,26 @@ impl TransactionStatusResponse {
                 tx.to_addr.is_some().then(|| hex::encode(&tx.payload)),
             ),
         };
-        let status_code = if receipt.accepted.is_some() && receipt.accepted.unwrap() {
-            TxnStatusCode::Confirmed
-        } else if receipt.accepted.is_none() {
-            TxnStatusCode::Dispatched
-        } else {
-            let errors: Vec<ScillaError> =
-                receipt.errors.into_iter().flat_map(|(_k, v)| v).collect();
-            if errors.len() == 1 {
-                match errors[0] {
-                    ScillaError::CallContractFailed => TxnStatusCode::FailScillaLib,
-                    ScillaError::CreateContractFailed => TxnStatusCode::Error,
-                    ScillaError::GasNotSufficient => TxnStatusCode::InsufficientGas,
-                    ScillaError::BalanceTransferFailed => TxnStatusCode::InsufficientBalance,
-                    _ => TxnStatusCode::Error,
-                }
+        let status_code =
+            if receipt.accepted.is_some() && receipt.accepted.unwrap() && receipt.success {
+                TxnStatusCode::Confirmed
+            } else if receipt.success {
+                TxnStatusCode::Dispatched
             } else {
-                TxnStatusCode::Error
-            }
-        };
+                let errors: Vec<ScillaError> =
+                    receipt.errors.into_iter().flat_map(|(_k, v)| v).collect();
+                if errors.len() == 1 {
+                    match errors[0] {
+                        ScillaError::CallContractFailed => TxnStatusCode::FailScillaLib,
+                        ScillaError::CreateContractFailed => TxnStatusCode::Error,
+                        ScillaError::GasNotSufficient => TxnStatusCode::InsufficientGas,
+                        ScillaError::BalanceTransferFailed => TxnStatusCode::InsufficientBalance,
+                        _ => TxnStatusCode::Error,
+                    }
+                } else {
+                    TxnStatusCode::Error
+                }
+            };
         let modification_state = if receipt.accepted.is_none() { 0 } else { 2 };
         Ok(Self {
             id: tx.hash.to_string(),