Dev #53
Merged
Dev #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chcmedeiros
commented
Jul 25, 2024
•
chcmedeiros
commented
- Support v0.40.0; Closes Support expanded Namada 0.40.0 test vectors #49 ;
- Support Flex device;
- Closes Murisi/generalized transfers #51 , closes Fix the printing of change metadata transactions #55 and closes Fixed update account transaction signing #54
chcmedeiros
force-pushed
the
dev
branch
3 times, most recently
from
3a916da to
39d4414
Compare
ftheirs
reviewed
Jul 25, 2024
| return parser_unexpected_error; | ||
| } | ||
|
|
||
| for(*nonce = 0; *nonce <= 255; (*nonce) ++) { |
ftheirs
reviewed
Jul 25, 2024
app/src/parser_print_txn.c
Outdated
| return parser_unexpected_error; | ||
| } | ||
| const uint8_t tmpOffset = strnlen(tmpBuffer, sizeof(tmpBuffer)); | ||
| tmpBuffer[tmpOffset] = '-'; |
There was a problem hiding this comment.
You can use this and get rid of the +/-1 in the following line
tmpBuffer[tmpOffset++] = '-';
ftheirs
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.