Masp Fixes & Improvements #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove unused parameters from rs method * fix convert checks * update zemu * update snapshots * format rust * improve indices handling * add shielded hash verification * update rs lib * fix signature index * don't clean randomness buffer after last signature * allow presence of dummy notes * fix convert descriptions offset * check random number only on sign_masp_spends * update version & snapshots * logic improvements
* remove some pointer arithmetic * update apdu spec * adding masp flow state checking * removing local js package * add js package as a submodule * add tests to verify wrong state rejection
emmanuelm41
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.