Merge pull request #41 from Zondax/fix/drop

Fix dropping reference warning
Zondax · Dec 9, 2024 · 6436845 · 6436845
2 parents d840e1a + d901475
commit 6436845
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -34,9 +34,9 @@ jobs:
           rustup show
       - name: rustfmt
         run: |
-          cargo fmt --version
+          # cargo fmt --version
           cargo fmt -- --check
       - name: clippy
         run: |
-          cargo clippy --version
+          # cargo clippy --version
           cargo clippy --all-targets
diff --git a/zemu/src/ui_toolkit/backends/nanosplus.rs b/zemu/src/ui_toolkit/backends/nanosplus.rs
@@ -141,7 +141,11 @@ impl UIBackend<KEY_SIZE> for NanoSPBackend {
     }
 
     fn message_buf(&mut self) -> Self::MessageBuf {
-        core::mem::drop(self);
+        // core::mem::drop(self);
+        // We do not know what is self, but the compiler
+        // does, so let it know we are done with self
+        // at this point
+        _ = self;
 
         core::str::from_utf8_mut(&mut Self::static_mut().message)
             //this should never happen as we always asciify

diff --git a/zemu/src/ui_toolkit/backends/nanox.rs b/zemu/src/ui_toolkit/backends/nanox.rs
@@ -141,7 +141,10 @@ impl UIBackend<KEY_SIZE> for NanoXBackend {
     }
 
     fn message_buf(&mut self) -> Self::MessageBuf {
-        core::mem::drop(self);
+        // We do not know what is self, but the compiler
+        // does, so let it know we are done with self
+        // at this point
+        _ = self;
 
         core::str::from_utf8_mut(&mut Self::static_mut().message)
             //this should never happen as we always asciify