Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pdb dataset fix #86

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Pdb dataset fix #86

merged 5 commits into from
Mar 20, 2024

Conversation

kierandidi
Copy link
Collaborator

Fix the PDB dataset to

  • avoid redownloading the whole dataset if it is already present on disk
  • remove import issues and unpacking problems in the download method

@kierandidi kierandidi requested a review from a-r-j March 13, 2024 19:06
a-r-j
a-r-j requested changes Mar 14, 2024
View reviewed changes
Copy link
Owner

@a-r-j a-r-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of nits. Appreciate the PR!

proteinworkshop/datasets/pdb_dataset.py Show resolved Hide resolved
proteinworkshop/datasets/pdb_dataset.py Show resolved Hide resolved
@a-r-j a-r-j merged commit 380a738 into main Mar 20, 2024
8 checks passed
@amorehead amorehead deleted the pdb_dataset_fix branch March 20, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorehead amorehead amorehead left review comments

@a-r-j a-r-j a-r-j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kierandidi @amorehead @a-r-j