Repository navigation
Update to @abap2ui5/linter 0.8.0 / linter-render and fix its findings - #83
Merged
Merged
Conversation
- unused-namespace-declaration (37): drop the xmlns declarations no element of the view or fragment uses - event-arg-default-index (11): get_event_arg( ) instead of spelling out the default index 1 - unbound-public-attribute (5): move state no binding reaches to PROTECTED (Z2UI5_CL_SMPS_APP_319, _485, _486, _490) - redundant-init-display (1): Z2UI5_CL_SMPS_APP_486 keeps only the check_on_navigated( ) branch, which check_on_init( ) implies - editable-control-without-binding (1): Z2UI5_CL_SMPS_APP_484 binds the "Launchpad active" field like the two fields above it - frontend-action-as-backend-event (3) and client-handle-capture (1): the overview app's own event constant is renamed cs_backend_event so it no longer reads as the client's frontend-action cs_event, and the header press is written at the control as one COND instead of a captured handle - handler-without-event (16) and smart-variant-without-init (1): linter false positives - a CASE over operators (Z2UI5_CL_SMPS_APP_319) and over JSON escape characters (Z2UI5_CL_SMPS_APP_489), and a variant management initialised through cs_event-filter_bar_variant_init (Z2UI5_CL_SMPS_APP_493) - suppressed with a directive block and the reason Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014bLQZPXbB8xmewCNmnBJaG
…der, @abaplint/cli 2.120.60 - @abap2ui5/linter ^0.6.1 -> ^0.8.0 - @abap2ui5/render-runtime ^0.6.1 -> @abap2ui5/linter-render ^0.8.0: the render runtime is published under the new name from 0.8.0 on, and render-runtime is deprecated at 0.7.0 - @abaplint/cli ^2.120.59 -> ^2.120.60 - bump-linter installs @abap2ui5/linter-render at the linter's version and falls back to @abap2ui5/render-runtime only for a version the new name has no release of, removing the other name so only one runtime is declared - check-abap2UI5 and abap2ui5lint.jsonc comments name the new package - check-abap2UI5 badge: 156 rules passed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014bLQZPXbB8xmewCNmnBJaG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the repo's three npm dependencies.
npm outdatedis now empty.Dependencies
@abap2ui5/linter^0.6.1 → ^0.8.0.@abap2ui5/render-runtime→@abap2ui5/linter-render^0.8.0.@abaplint/cli→ ^2.120.60.Workflows and comments
bump-linter.yamlinstallslinter-renderand falls back to the old name only for versionslinter-renderdoesn't have. It keeps just one of the two declared.check-abap2UI5.yamlandabap2ui5lint.jsoncnow name the new package.Linter 0.8.0 findings: all 76 resolved (11 warnings, 65 hints)
Fixed in code (58):
xmlns:core/form/tntdeclarations in 29 classes.get_event_arg( 1 )→get_event_arg( ).cs_eventconstant is renamed tocs_backend_event, because the linter read it asclient->cs_event.COND #( ).Suppressed with a disable/enable block and a reason comment (18), all linter false positives:
filter_bar_variant_init, which does initialise the variant.Checks:
npm run checkpasses: abaplint 0 issues, and the linter plus render gate report 0 findings (37 documents rendered).🤖 Generated with Claude Code
https://claude.ai/code/session_014bLQZPXbB8xmewCNmnBJaG
Generated by Claude Code