Repository navigation
Linter 0.8.1: drop the workaround directives in apps 319, 489 and 493 - #85
Merged
Merged
Conversation
0.8.1 counts only the WHENs of a CASE over the event for handler-without-event and accepts filter_bar_variant_init for smart-variant-without-init, so under it these blocks are unused-directive hints: - Z2UI5_CL_SMPS_APP_319: handler-without-event around the CASE over the condition operator, with the comment that explained it - Z2UI5_CL_SMPS_APP_489: handler-without-event around the CASE over the escape character, with the comment that explained it - Z2UI5_CL_SMPS_APP_493: smart-variant-without-init around the SmartVariantManagement; the comment keeps which handshake it uses Z2UI5_CL_SMPS_APP_000 keeps cs_backend_event: the name is clearer than cs_event next to the client's own constant regardless of the linter, so only its ABAP Doc stops giving the linter as a reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014bLQZPXbB8xmewCNmnBJaG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies:
@abap2ui5/linterand@abap2ui5/linter-render^0.8.0 → ^0.8.1.Workarounds removed:
Z2UI5_CL_SMPS_APP_319and_489: thehandler-without-eventblocks and their "the linter reads any WHEN as a handler" comments. 0.8.1 only counts WHENs of a CASE over the event.Z2UI5_CL_SMPS_APP_493: thesmart-variant-without-initblock. 0.8.1 knowsfilter_bar_variant_init. The comment still says which handshake the app uses.Z2UI5_CL_SMPS_APP_000: the rename tocs_backend_eventstays because it is clearer. Its ABAP Doc no longer justifies it with the linter.Checks:
npm run checkis green: abaplint 0, abap2ui5lint "No findings detected" (32 files), plus overview, keywords, abapdoc, SAMPLES.md, catalogue, app-rules, atc, prose and derived. Badges and derived files are unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_014bLQZPXbB8xmewCNmnBJaG
Generated by Claude Code