Repository navigation
fix(10): seed the bound MessageStrip type so apps 013-015 load - #91
Merged
Merged
Conversation
The result/status strip binds its type to a string attribute that was only set in event handlers. On the first display it reached the browser as "", which is no sap.ui.core.MessageType, and UI5 terminated the app - even though the strip is hidden at that point. 013 failed on every start, 014 and 015 whenever the LLM was already configured. Seed the attribute with `Information`, the same way app 487 seeds its message type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EnEEHk62BMvVumgbRZ8ot5
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps 013 (settings), 014 (chat) and 015 (summarize) bind their result/status MessageStrip's
typeto a string attribute that only event handlers set. On the first display it reaches the browser as"", which is nosap.ui.core.MessageType, and UI5 terminates the app — even though the strip is hidden at that point:013 failed on every start; 014 and 015 whenever the LLM was already configured (their
config_checkonly sets the type in the "not configured" branch).The attribute now starts as
Information(DATA … TYPE string VALUE \Information`), the way app 487 already seeds its message type withNone`.Checks
npm run check: green (abaplint, abap2UI5 linter incl. render gate, catalogue/keywords/abapdoc/ATC checks)abap2UI5/linter gets a matching rule (
enum-bound-to-initial-field) in a separate PR; that rule and the render gate report the old 013.🤖 Generated with Claude Code
https://claude.ai/code/session_01EnEEHk62BMvVumgbRZ8ot5
Generated by Claude Code