Repository navigation
Update @abaplint/cli to 2.120.73 - #93
Open
oblomov-dev wants to merge 2 commits into
Open
oblomov-dev wants to merge 2 commits into
oblomov-dev wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
msg_get_by_oref assigned val->(name) with val typed TYPE any. abaplint
2.120.73 rejects that dereference below 7.57 ("val" is not a reference
variable), which failed the v754 builds of the 03-rap and 04-rap-draft
branches. lx is the same object cast to cx_root, and the dynamic ASSIGN
resolves the attribute on the dynamic type, as z2ui5_cl_util does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
@abaplint/clifrom ^2.120.71 to ^2.120.73 (lockfile regenerated bynpm install), so it is on the same version as the rest of the organisation (CONVENTIONS §4).@abap2ui5/linter/@abap2ui5/linter-renderare already on the latest release (0.8.5).The one new finding, fixed in its own commit
2.120.73 reports
src/00/00/z2ui5_cl_smps_context.clas.abap[452] - "val" is not a reference variable (check_syntax)in the v754 branch builds (create-package-branches, 03-rap and 04-rap-draft); the v757 lint ofmaindoes not.msg_get_by_orefdidASSIGN val->(lv_name)withval TYPE any. It now reads the attribute throughlx, the same object already cast tocx_roottwo lines above, exactly asz2ui5_cl_util=>msg_get_by_orefdoes in the framework; the dynamic ASSIGN resolves the name on the dynamic type, so the subclass attributes are still found.Checked locally
npm run checkpasses in full (pin, abaplint, abap2UI5 linter, overview, keywords, titles, abapdoc, SAMPLES.md, catalogue, app-rules, ATC, prose, derived, released-API).scripts/build-package-branch.mjs 03-rapand04-rap-draftfollowed bynpx abaplint ./abaplint.jsonc: 1 issue before the fix, 0 after.🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt