Repository navigation
Report a booking fee that is no number instead of failing the roundtrip - #95
Merged
Merged
Conversation
Z2UI5_CL_SMPS_APP_002, _005 and _010 take the booking fee as free text and move it into the CURR field of the travel inside the EML VALUE. A fee typed as 20,00 or abc raised CX_SY_CONVERSION_NO_NUMBER there, so Create, Save Draft and Activate ended in an HTTP 500 instead of an answer. The fee is now converted first and a message box names it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-4 review of the samples (iteration 2: error paths and edges).
Fixes
Z2UI5_CL_SMPS_APP_002,_005,_010- booking fee typed as20,00orabc. The fee is a free-text field in the form / popup and goes into the CURR fieldBookingFeeinside the EMLVALUE #( ). A value that is no ABAP number raisedCX_SY_CONVERSION_NO_NUMBERthere, so Create (002, 005) and Save Draft / Activate (010) ended in an HTTP 500 with the runtime's exception text. The fee is now converted into the table field's type first; a value that does not convert gets a message box naming it, and the form keeps what the user typed.Checked locally
npm run checkgreen (abaplint, abap2UI5-linter, overview, keywords, titles, abapdoc). The per-branch builds (03-rap,04-rap-draftat 7.54 and Cloud) run increate-package-brancheson this pull request.🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Generated by Claude Code