Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n/a #6

Open
wants to merge 181 commits into
base: master
Choose a base branch
from
Open

n/a #6

wants to merge 181 commits into from

Conversation

jayporta
Copy link

@jayporta jayporta commented Oct 18, 2017

No description provided.

invacuo and others added 14 commits October 17, 2017 23:38
***Why is this change necessary?***
We need to add a button next to the "Play Now - It's open" button that will have the text "Contribute Now - It's on GitHub" that points to https://github.com/itidigitalbr/privacy-board-game

***How does this accomplish the change?***
- Added required html
- Updated the css class names to be more generic so that they match both the buttons
- Added required css to align the buttons next to each other
Added individual images
Add new button for "Contribute Now - It's on GitHub"
Add new button for Contribute Now - Its on GitHub issues #57
svg logo added name is logo.svg (same as before)
@jayporta jayporta changed the title Landing page CSS changes: Centering buttons, fixing background height/fill, and adjusting some spacing n/a Oct 18, 2017
jayporta and others added 15 commits October 18, 2017 18:38
Nothing has been removed. I commented things out and made additions. All are commented.

In index.html

Line 74: Added line break before animated span to avoid page jump while wrapping text.

All in lapax.css

Line 25: Commented out 100vh from .header because the page was being cut off when scrolled.

Line 62: Added flexbox properties (with prefixes) to .header .button-wrapper for better centering.

Line 148: Reduced letter spacing on .header .logo on mobile from 15px to 12px, and added a 50px bottom margin for even spacing

Line 153: Commented out .header .container.hero and .header-content rules

Line 167:  Added an 80px top margin to .header .hero-content on desktop

Line 185: Added 30px top margin on .header .hero-content on mobile

Line 252: Added media query for iPhone 5/SE and smaller for .btn-download. Decreases padding and font-size slightly to fit the display.
Moved nav header outside of main content (.header)

Line 1: Gave body 100vh
Line  10: Moved background to #lapax body background so there isnt' a white section when scrolled
Line 26: increased .header min-height
Line 20: Added flexbox properties to .header
Line 43: Added media query range for .header margin when title text wraps
Line 49: Commented out .header min-height
Line 80: Added flexbox properties to button-wrapper classes for centering
Line: 101: Adjusted rule to reflect new .nav-header location (outside of .header)
Line: 105 106: Added top and left for fixed header
Line 115 - 130: Adjusted rule to reflect new .nav-header location (outside of .header)
Line 166 167: Changed letter-spacing and added bottom margin to .header .logo
Line 170 - 183: Commented out .container.hero height and .hero-content transform properties
Line 216 - 231: Adjusted rule to reflect new .nav-header location (outside of .header)
 Homepage/landing page fixes for improved responsiveness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.