-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
n/a #6
Open
jayporta
wants to merge
181
commits into
abbycabs:master
Choose a base branch
from
itidigitalbr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
n/a #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start development
remove macOS files, add gitignore and editorconfig
***Why is this change necessary?*** We need to add a button next to the "Play Now - It's open" button that will have the text "Contribute Now - It's on GitHub" that points to https://github.com/itidigitalbr/privacy-board-game ***How does this accomplish the change?*** - Added required html - Updated the css class names to be more generic so that they match both the buttons - Added required css to align the buttons next to each other
Added individual images
Add new button for "Contribute Now - It's on GitHub"
Add new button for Contribute Now - Its on GitHub issues #57
svg logo added name is logo.svg (same as before)
jayporta
changed the title
Landing page CSS changes: Centering buttons, fixing background height/fill, and adjusting some spacing
n/a
Oct 18, 2017
Nothing has been removed. I commented things out and made additions. All are commented. In index.html Line 74: Added line break before animated span to avoid page jump while wrapping text. All in lapax.css Line 25: Commented out 100vh from .header because the page was being cut off when scrolled. Line 62: Added flexbox properties (with prefixes) to .header .button-wrapper for better centering. Line 148: Reduced letter spacing on .header .logo on mobile from 15px to 12px, and added a 50px bottom margin for even spacing Line 153: Commented out .header .container.hero and .header-content rules Line 167: Added an 80px top margin to .header .hero-content on desktop Line 185: Added 30px top margin on .header .hero-content on mobile Line 252: Added media query for iPhone 5/SE and smaller for .btn-download. Decreases padding and font-size slightly to fit the display.
Moved nav header outside of main content (.header) Line 1: Gave body 100vh Line 10: Moved background to #lapax body background so there isnt' a white section when scrolled Line 26: increased .header min-height Line 20: Added flexbox properties to .header Line 43: Added media query range for .header margin when title text wraps Line 49: Commented out .header min-height Line 80: Added flexbox properties to button-wrapper classes for centering Line: 101: Adjusted rule to reflect new .nav-header location (outside of .header) Line: 105 106: Added top and left for fixed header Line 115 - 130: Adjusted rule to reflect new .nav-header location (outside of .header) Line 166 167: Changed letter-spacing and added bottom margin to .header .logo Line 170 - 183: Commented out .container.hero height and .hero-content transform properties Line 216 - 231: Adjusted rule to reflect new .nav-header location (outside of .header)
Homepage/landing page fixes for improved responsiveness
Removing text-shadow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.