Repository navigation
RTL4m1: decode the subscribe mode flag as MESSAGE_SUBSCRIBE - #555
Merged
Merged
Conversation
TR3s SUBSCRIBE and TR3u MESSAGE_SUBSCRIBE share a flag value, so RTL4m didn't say which one an SDK should report in RealtimeChannel.modes. Specify the preferred variant, and update the RTL4m UTS test to match. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Follows up the TR3u rename, which updated features.md but not the docstrings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
SimonWoolf
enabled auto-merge
October 9, 2026 16:23
SimonWoolf
force-pushed
the
rtl4m-message-subscribe
branch
from
October 9, 2026 16:23
938646a to
eb2a2b6
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 70acf87 (TR3u), which added
MESSAGE_SUBSCRIBEas the preferred synonym forSUBSCRIBE. Both names share a flag value, soRTL4mdoesn't say which one an SDK should report inRealtimeChannel.modes.RTL4m1: where more than oneChannelModecorresponds to the same flag,modesmust contain only the preferred variant, so the subscribe flag is decoded asMESSAGE_SUBSCRIBE.RTL4mUTS test to assertmessage_subscribe. The test ID is unchanged, so existing SDK ports still map to it.MESSAGE_SUBSCRIBEto theChannelModedocstrings, which the original rename missed.ably-js implementation: ably/ably-pubsub-js#2317
🤖 Generated with Claude Code