Skip to content

Use urljoin to construct catalog URLs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keshav-space merged 1 commit into from
Sep 30, 2025
Merged

Use urljoin to construct catalog URLs #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions sync_catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from datetime import datetime
from datetime import timezone
from pathlib import Path
from urllib.parse import urljoin

import requests

Expand All @@ -34,7 +35,7 @@ def steps(cls):

def check_new_catalog(self):
start_page = self.get_catalog_page_count()
self.fetch_and_write(f"{self.url}/index.json", CATALOG_INDEX)
self.fetch_and_write(urljoin(self.url, "index.json"), CATALOG_INDEX)
end_page = self.get_catalog_page_count()
self.pages_to_collect = range(start_page, end_page)

Expand All @@ -47,10 +48,10 @@ def collect_new_catalog(self):
logger=self.log,
)
for page in progress.iter(latest_pages):
page_id = f"page{page}"
page_id = f"page{page}.json"
self.fetch_and_write(
url=f"{self.url}{page_id}.json",
path=PAGE_DIRECTORY / f"{page_id}.json",
url=urljoin(self.url, page_id),
path=PAGE_DIRECTORY / page_id,
)

def log(self, message):
Expand Down