Python3 support - #293
Merged
Merged
Conversation
* also add Python to Travis test matrix * use the Python interepreter in the path by default on POSIX Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* we still have unicode and CSV issues but only a few Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* and fix tests accordingly Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* instead use a flag that is passed around as needed Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
force-pushed
the
291-280-python3-support
branch
from
November 6, 2017 13:11
99c1ca3 to
ea3b522
Compare
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Ensure CSV tests use sorted checks #280 * use different expectations for Python 2 and 3 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Use cvs and not backports.csv on Pyhton 3 * Reference .ABOUT files consistently * Enable using -h as a help option shortcut * Improve the help for the main entry point and each command * cleanup the setup.py Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com> Do not subclass csv.DictReader on Python 3 #280 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com> Do not require backports.csv on Python3 #280 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com> Do not require backports.csv on Python3 #280 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com> Use proper subclass of csv.DictReader on Python 2 #280 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Member
|
@tdruez @chinyeungli ready for your review! |
pombredanne
force-pushed
the
291-280-python3-support
branch
from
November 6, 2017 16:20
cd60a1e to
0059953
Compare
Member
|
@tdruez This PR also incorporates all the changes you made in https://github.com/nexB/aboutcode-toolkit/compare/280-python3 and more. And it does not require nor forces the installation of unicodecsv on Python 3 thanks to this: https://github.com/nexB/aboutcode-toolkit/pull/293/files#diff-2eeaed663bd0d25b7e608891384b7298R87 ;) |
…ity #280 Signed-off-by: Thomas Druez <tdruez@nexb.com>
Contributor
|
@pombredanne the code looks good. Almost ready for merge but first, I think we need to fix this one: https://github.com/nexB/aboutcode-toolkit/blob/291-280-python3-support/setup.py#L69 When installing aboutcode-toolkit as a library with pip, an
This is not needed. |
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* and other setup/packaging improvements Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers the remaining bits for the Python 3 port #280 and fixes #291