Improve boolean field handling #327 - #358
Closed
chinyeungli wants to merge 1 commit into
Closed
Conversation
Fixed the bugs that's reported in the comment on Jun 12. It will now report the 'no' in both `gen` and `inventory`. After some thought, I think we should just keep the `y, yes, n, no` and ignore everything else. Some users may use 'x' to represent False and 'tick' as True, so we cannot assume 'x' to be True. Current behavior: `y or yes` will consider as True `n or no` will consider as False 'blank' will gives warning saying the field is present but empty Signed-off-by: Chin Yeung Li <tli@nexb.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bugs that's reported in the comment on Jun 12 in #327
It will now report the 'no' in both
genandinventory.After some thought, I think we should just keep the
y, yes, n, noandignore everything else. Some users may use 'x' to represent False and
'tick' as True, so we cannot assume 'x' to be True.
Current behavior:
y or yeswill consider as Truen or nowill consider as False'blank' will gives warning saying the field is present but empty
Signed-off-by: Chin Yeung Li tli@nexb.com