Skip to content

Fix minor typos. - #3

Merged
pombredanne merged 3 commits into
aboutcode-org:masterfrom
kartiksibal:patch-1
May 9, 2017
Merged

Fix minor typos.#3
pombredanne merged 3 commits into
aboutcode-org:masterfrom
kartiksibal:patch-1

Conversation

@kartiksibal

@kartiksibal kartiksibal commented Apr 30, 2017

Copy link
Copy Markdown
Contributor

@pombredanne Some off the top errors I could find.
Signed-off-by: Kartik Sibal kartiksibal@gmail.com

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made a few minor comments.

Comment thread aboutcode-data/README.rst Outdated
Alternatively Packages could be extracted to an independent PackagedCode library.

The changes will minimal impact onthe layout of the scan results. Here is an
The changes will minimise impact on the layout of the scan results. Here is an

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we stay with US English there? ;) e.g. "minimize"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pombredanne haha sure. ;-)

Comment thread aboutcode-data/README.rst Outdated

- A tool that generates attribution documentation may be interested
first by components and second by licenses or packages references.
- A tool that generates attribution documentation may interest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO may be interested by components first is still valid: I am talking about the the interest or focus of a tool there

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pombredanne umm, that should work too.
But, "may be interested first by components and second by licenses or packages references.", seemed a tad odd.
But, again. English isn't my mother tongue, so you are a better judge. 😅

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it is no mine either. Let's go with:
A tool that generates attribution documentation may focus first on components and second on licenses or packages references.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pombredanne Done. 👍

Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
Signed-off-by: Kartik Sibal <kartiksibal@gmail.com>
@pombredanne

Copy link
Copy Markdown
Member

Thanks!

@pombredanne
pombredanne merged commit 81b4dbb into aboutcode-org:master May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants