Fix silently discarded error in insert_purls() - #12
Closed
krisharma955 wants to merge 2 commits into
Closed
Conversation
Handle the error returned by os.ReadFile() in insert_purls instead of discarding it with _. Previously, if a data file could not be read, zero PURLs were silently inserted into the FST with no indication of failure. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com> Signed-off-by: krishsharma955 <krishsharma9005@gmail.com>
krisharma955
force-pushed
the
fix/silent-error-swallowing
branch
from
September 4, 2026 16:09
4228cbc to
2620be5
Compare
… leak Replace init() with sync.Once lazy initialization in purlvalidator.go so the library no longer crashes consumers on FST load failure. Add defer f.Close() in cmd/main.go to prevent file descriptor leak. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s.ReadFile() error was being thrown away with
_in insert_purls().If the file is missing/unreadable/corrupt, it just carries on with
empty data and inserts zero PURLs — no error, no warning, nothing.
Changed it to check err and log.Fatal() like the rest of the file
already does. Also dropped the leftover
var err errorsince:=takes care of it now.