relative links_fix by gmathiou4 · Pull Request #134 · aboutcode-org/python-inspector

gmathiou4 · 2023-06-15T08:15:11Z

This a fix for issue
#129

It adds the ability to handle relative links
first check if a link is relative and joining to the full package url

Signed-off-by: Georgios Mathioudakis georgios.mathioudakis@here.com

TG1999 · 2023-06-15T16:02:19Z

@gmathiou4 thanks for the PR, it would be nice if you could add some tests to verify your changes.

gmathiou4 · 2023-06-16T15:34:58Z

@TG1999

Still i have 2 failing tests unrelated to my changes

FAILED tests/test_codestyle.py::BaseTests::test_codestyle - Exception: ('Code style check failed!', b"-> Run pycodestyle (PEP8) validation\n./inspec/lib/python3.11/site-packages/pip_requirements_parser.py:103:77: W291 trailing whitespac...
FAILED tests/test_resolution.py::test_without_supported_wheels - AttributeError: 'IfExp' object has no attribute 'elts'

How would you suggest to proceed with those?

TG1999 · 2023-06-20T07:39:33Z

@gmathiou4 for
FAILED tests/test_codestyle.py::BaseTests::test_codestyle - Exception: ('Code style check failed!', b"-> Run pycodestyle (PEP8) validation\n./inspec/lib/python3.11/site-packages/pip_requirements_parser.py:103:77: W291 trailing whitespac

Please run make valid command

TG1999 · 2023-06-20T07:44:07Z

@gmathiou4 I ran the tests on your branch locally, I was not able to re-create this error
FAILED tests/test_resolution.py::test_without_supported_wheels - AttributeError: 'IfExp' object has no attribute 'elts'

gmathiou4 · 2023-06-27T11:03:48Z

@TG1999 The tests are fixed now, please proceed with the review

TG1999

Please add a test for the package which have relative URLs to check the whole functionality

TG1999 · 2023-06-27T11:32:51Z

                python_requires = anchor_tag.attrs["data-requires-python"]
+            # Check if the link is a relative URL
+            if not url.startswith(("http://", "https://")):
+                base_url = "/".join(package_url.split("/")[:-1])  # Extract base URL


Please extract this part of code in a separate function and add some doctest or unit tests for same.

Hello @TG1999 , i have already added 2 new files for the test
tests/data/fetch_links_test.html
tests/data/relative-links-expected.json
and modified
tests/test_utils.py

Those tests aren't suitable?

@TG1999 Could you please provide a feedback, is the change ready for merge?

TG1999 · 2023-07-03T09:03:02Z


+def resolve_relative_url(package_url, url):
+    """
+    Resolve a relative URL based on the package URL.


Please add some doctests

TG1999 · 2023-07-03T09:03:42Z

@gmathiou4 thanks! just a minor nitpick for your consideration #134 (comment)

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

gmathiou4 · 2023-08-03T08:50:23Z

Hello,
Could you please review the changes and let me know if you have another suggestion before the merge?

TG1999 · 2023-08-03T11:29:35Z

@gmathiou4 please squash your commits

TG1999

LGTM!

pombredanne · 2023-08-03T14:30:45Z

@TG1999 the tests are failing... may be a skeleton issue? I see also #119 ... so I guess I'll approve and we can do it later.

pombredanne

@TG1999 Ready to merge when you are ready
@gmathiou4 Thank you ++ ❤️

TG1999 · 2023-08-03T14:41:02Z

@TG1999 the tests are failing... may be a skeleton issue? I see also #119 ... so I guess I'll approve and we can do it later.

@pombredanne CI is failing due to this sphinx-doc/sphinx#11381

TG1999 · 2023-08-03T14:41:26Z

Thanks @gmathiou4 merging ❤️

gmathiou4 · 2023-08-04T10:02:48Z

@TG1999, Thanks for merging!
Could you please help me clarify, if "main"= "tag 0.9.7".
If not, does that means that always the latest version is the main branch?

gmathiou4 · 2023-08-07T14:35:28Z

@TG1999 & @pombredanne Could you please release a new tag with the latest changes?

TG1999 · 2023-08-07T15:36:15Z

@gmathiou4 released v0.9.8 here https://pypi.org/project/python-inspector/0.9.8/

gmathiou4 force-pushed the Relative-links-confuse-PyPi branch 2 times, most recently from 3513ff1 to 18f1b90 Compare June 15, 2023 14:14

gmathiou4 force-pushed the Relative-links-confuse-PyPi branch 3 times, most recently from aed1540 to f5a3fc6 Compare June 16, 2023 15:13

gmathiou4 force-pushed the Relative-links-confuse-PyPi branch 2 times, most recently from 52d1969 to e987814 Compare June 19, 2023 14:43

This comment was marked as outdated.

Sign in to view

gmathiou4 force-pushed the Relative-links-confuse-PyPi branch 6 times, most recently from 37e01f6 to e027c0d Compare June 26, 2023 16:51

TG1999 reviewed Jun 27, 2023

View reviewed changes

gmathiou4 force-pushed the Relative-links-confuse-PyPi branch 2 times, most recently from 2d1fe9e to db27f06 Compare June 28, 2023 11:52

TG1999 reviewed Jul 3, 2023

View reviewed changes

gmathiou4 force-pushed the Relative-links-confuse-PyPi branch 6 times, most recently from eb3c585 to 6f35786 Compare July 13, 2023 08:12

mathioud added 15 commits July 31, 2023 13:24

add doctest for the newly created function

9797300

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

update tests

2af3691

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

update tests versions

9e63f97

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

update tests version

a2343c6

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

update tests version

e007a45

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

update tests version

8f5da96

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

update tests version

2f35337

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

update tests files version

06bd3c6

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

imrove doctest

714d672

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

update tests files version and doctest

106ca54

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

update tests files version

77b2683

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

fix doctest typo

f37745f

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

Fix tests

7d065b0

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

change logic to urlparse & update doctests

6b3b3a5

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

Fix relative test

b74a7c3

Signed-off-by: mathioud <georgios.mathioudakis@here.com>

gmathiou4 force-pushed the Relative-links-confuse-PyPi branch from d5e7c18 to b74a7c3 Compare July 31, 2023 11:24

gmathiou4 requested review from TG1999 and pombredanne July 31, 2023 11:34

TG1999 approved these changes Aug 3, 2023

View reviewed changes

pombredanne approved these changes Aug 3, 2023

View reviewed changes

TG1999 merged commit e5043a8 into aboutcode-org:main Aug 3, 2023

sschuberth mentioned this pull request Feb 29, 2024

Relative links confuse PyPi #129

Closed

Uh oh!

Uh oh!

Conversation

gmathiou4 commented Jun 15, 2023

Uh oh!

TG1999 commented Jun 15, 2023

Uh oh!

gmathiou4 commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TG1999 commented Jun 20, 2023

Uh oh!

TG1999 commented Jun 20, 2023

Uh oh!

This comment was marked as outdated.

gmathiou4 commented Jun 27, 2023

Uh oh!

TG1999 left a comment

Choose a reason for hiding this comment

Uh oh!

TG1999 Jun 27, 2023

Choose a reason for hiding this comment

Uh oh!

gmathiou4 Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gmathiou4 Jun 29, 2023

Choose a reason for hiding this comment

Uh oh!

TG1999 Jul 3, 2023

Choose a reason for hiding this comment

Uh oh!

TG1999 commented Jul 3, 2023

Uh oh!

gmathiou4 commented Aug 3, 2023

Uh oh!

TG1999 commented Aug 3, 2023

Uh oh!

TG1999 left a comment

Choose a reason for hiding this comment

Uh oh!

pombredanne commented Aug 3, 2023

Uh oh!

pombredanne left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TG1999 commented Aug 3, 2023

Uh oh!

TG1999 commented Aug 3, 2023

Uh oh!

gmathiou4 commented Aug 4, 2023

Uh oh!

gmathiou4 commented Aug 7, 2023

Uh oh!

TG1999 commented Aug 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gmathiou4 commented Jun 16, 2023 •

edited

Loading

gmathiou4 Jun 28, 2023 •

edited

Loading

pombredanne left a comment •

edited

Loading