Skip to content

Add authentication for private repos - #28

Merged
TG1999 merged 1 commit into
mainfrom
authentication
Jun 24, 2022
Merged

Add authentication for private repos#28
TG1999 merged 1 commit into
mainfrom
authentication

Conversation

@TG1999

@TG1999 TG1999 commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

Reference: #8
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999
TG1999 force-pushed the authentication branch 6 times, most recently from 22f7313 to 77e687a Compare June 24, 2022 12:31
@TG1999
TG1999 requested review from JonoYang and pombredanne June 24, 2022 12:31

@JonoYang JonoYang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a code logic suggestion, but other than that, its looking good!

Comment thread src/python_inspector/utils_pypi.py Outdated
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@JonoYang
JonoYang self-requested a review June 24, 2022 21:12

@JonoYang JonoYang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TG1999
TG1999 merged commit b46a8d0 into main Jun 24, 2022
@TG1999
TG1999 deleted the authentication branch July 11, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants