Skip to content

Add resolution for dependencies - #7

Merged
pombredanne merged 19 commits into
mainfrom
resolution
Jun 14, 2022
Merged

Add resolution for dependencies#7
pombredanne merged 19 commits into
mainfrom
resolution

Conversation

@TG1999

@TG1999 TG1999 commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999
TG1999 force-pushed the resolution branch 2 times, most recently from db8742c to ee35e70 Compare June 13, 2022 16:14
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne and others added 18 commits June 14, 2022 10:07
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Especially support line of up to 100 chars

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Change format_resolution() args to return only either a tree or a
parent/children structure. List is not needed.
* rename resolution() to get_resolved_dependencies()

*Streamline imports

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Change resuults returned by resolve() to be a tuple of
  (initial_requirements, resolved_dependencies)
* Refine doc and doc strings
* Use stderr for CLI messages

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Make it data driven and test the whole result againsta  JSON file
* Add new test for a requirements files
* Use regeneration of fixtures with the PYINSP_REGEN_TEST_FIXTURES=yes
  environment variable.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* This help better understand what comes from where.
* Also add missing ISC license

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Add new CLI flag "--use-pypi-json-api" to use exclusively the PyPI
  fast but incorrect JSON API.
* Remove pypi_simple_repo_in_repos() from 'python_inspector.resolution'
  This is not longer needed
* Also remove dangerous globals from function and methods arguments:
  * PythonInputProvider.__init__() where repos was a mutable list
  * get_resolved_dependencies() where repos was a mutable list
* Refactor methods that dealt with PyPI JSON vs. simple by splitting
  them in two specialized methods

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
merging!

@pombredanne
pombredanne merged commit b6e5f4c into main Jun 14, 2022
@pombredanne
pombredanne deleted the resolution branch June 14, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants