Skip to content

License data cleanup - #1317

Merged
pombredanne merged 3 commits into
developfrom
license-data-cleanup
Dec 17, 2018
Merged

pombredanne merged 3 commits into
developfrom
license-data-cleanup

Conversation

@sschuberth

Copy link
Copy Markdown
Collaborator

Please have a look at the individual commit messages for the details.

Replace the empty file in "src" with a copy from "tests". While at it,
strip trailing space.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Having these removed allows for automatically creating nicer NOTICE
files quoting the license texts.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth

Copy link
Copy Markdown
Collaborator Author

@pombredanne, I hope these changes are feasible (and the files I'm changing are e.g. not auto-generated).

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful. Thanks! I guess this help generate cleaner and better looking attribution notice.

@pombredanne

Copy link
Copy Markdown
Member

Do not worry about the test failures, I have that under control and they are not your doing.

@@ -0,0 +1,14 @@

All code contained in this distributed is placed in the public domain.
=============================================================

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is another bug you found altogether and that I will fix when merging: there should not be a dangling .LICENSE file like this

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, there is no aes-128-3.0 ... there is instead a public-domain-disclaimer which is a public domain dedication with a warranty disclaimer.

@pombredanne

Copy link
Copy Markdown
Member

This has been merged in #1318 which will be merged soon in develop

@pombredanne
pombredanne merged commit d525485 into develop Dec 17, 2018
@pombredanne
pombredanne deleted the license-data-cleanup branch December 17, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants