Skip to content

Regen test fixtures and fix tests after scancode-toolkit upgrade - #1997

Merged
tdruez merged 2 commits into
mainfrom
update-toolkit
Dec 15, 2025
Merged

Regen test fixtures and fix tests after scancode-toolkit upgrade#1997
tdruez merged 2 commits into
mainfrom
update-toolkit

Conversation

@AyanSinhaMahapatra

@AyanSinhaMahapatra AyanSinhaMahapatra commented Dec 12, 2025

Copy link
Copy Markdown
Member

Reference: #1984

@AyanSinhaMahapatra
Regen test fixtures and fix tests
9422a81 
Reference: #1984
Signed-off-by: Ayan Sinha Mahapatra <asmahapatra@aboutcode.org>
AyanSinhaMahapatra
AyanSinhaMahapatra commented Dec 12, 2025
View reviewed changes
Comment thread scanpipe/pipes/spdx.py
Comment thread scanpipe/tests/regen_test_data.py
@AyanSinhaMahapatra

AyanSinhaMahapatra commented Dec 12, 2025

Copy link
Copy Markdown
Member Author

@tdruez I had some more changes related to #1984 as that was not complete.

I cannot reproduce the warnings in #1984 (comment) though I think I've seen them before. It could be related to the click failures which we fixed earlier. Let me know if they still persist. Same about the UNSET_files but I can track these seperately.

We are also failing on the scorecard data checks as I think the scorecard API data format has changed. Also opening an issue and investigating/fixing this seperately.

AyanSinhaMahapatra
AyanSinhaMahapatra commented Dec 12, 2025
View reviewed changes
Comment thread scanpipe/tests/pipes/test_output.py
@tdruez
Do not rely on UUID to get package object
7f40d10 
Signed-off-by: tdruez <tdruez@aboutcode.org>
@tdruez tdruez mentioned this pull request Dec 15, 2025
Closed
@tdruez

tdruez commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

I cannot reproduce the warnings in #1984 (comment) though I think I've seen them before. It could be related to the click failures which we fixed earlier. Let me know if they still persist. Same about the UNSET_files but I can track these seperately.

@AyanSinhaMahapatra This is an issue with commoncode, entered as #1998

@tdruez
tdruez merged commit 8712d48 into main Dec 15, 2025
14 checks passed
@tdruez
tdruez deleted the update-toolkit branch December 15, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdruez tdruez Awaiting requested review from tdruez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AyanSinhaMahapatra @tdruez