Create a ScanCode.io pipeline to integrate Grimoire - #2202
Conversation
5b50e5e to
cb46931
Compare
|
The pipeline input is: The expected JSON output file is: |
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Add a test for ScanRepoGrimoirelabTest Remove hardcoded env variable Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Validate VCS URL Add a test Update Grimoirelab to use the minimal setting Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Replace git:// with https:// Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Fix the tests. Ensure the pipeline runs only when it is correctly configured. Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Fix the test Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Add more validation over format_metrics_output step Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Fix a typo Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
feb8429 to
7ddcb72
Compare
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
b9d75ae to
47d06fb
Compare
keshav-space
left a comment
There was a problem hiding this comment.
Thanks @ziadhany, LGTM! few minor nits for your consideration.
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
|
@keshav-space I just updated the error messages and the function docstring. |
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Update the scan repo health expected output Signed-off-by: ziad hany <ziadhany2016@gmail.com>
|
@keshav-space I just added the docs for the pipeline and its configuration. Please review them when you have some time.
|
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
keshav-space
left a comment
There was a problem hiding this comment.
@ziadhany, see suggestion below.
| GRIMOIRELAB_ECOSYSTEM = environ.get("GRIMOIRELAB_ECOSYSTEM", "") | ||
| GRIMOIRELAB_PROJECT = environ.get("GRIMOIRELAB_PROJECT", "") |
There was a problem hiding this comment.
Yes, this is currently hardcoded in GrimoireLab, so the pipeline can only run with these values:
GRIMOIRELAB_ECOSYSTEM="npm-training-set"
GRIMOIRELAB_PROJECT="npm-popular-components"
We are planning to make these values configurable per ecosystem in the future.
In the meantime, according to my understanding, we will use the following hardcoded values for our pipeline:
GRIMOIRELAB_ECOSYSTEM="npm"
GRIMOIRELAB_PROJECT="health"
There was a problem hiding this comment.
@keshav-space, these will be the hardcoded values according to Tushar’s last meeting. I’ll update the docs accordingly.
GRIMOIRELAB_ECOSYSTEM="npmlargerecosystem"
GRIMOIRELAB_PROJECT="NPMMostUsed"
Fix a typo in the image documentation Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>


Issues